Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15313 - The compiler automatically generates an IsReadOnlyAttribute on downlevel frameworks even if we have already defined it. #15316

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Fix #15313 - The compiler automatically generates an IsReadOnlyAttribute on downlevel frameworks even if we have already defined it. #15316

merged 3 commits into from
Jun 6, 2023

Conversation

KevinRansom
Copy link
Member

Compilations where an IsReadOnlyAttribute is provided in source code fails due to an embedded IsReadOnlyAttribute.

Fix #15313

This fixes the issue by: filtering out and not embedding attributes which are provided in source code.

@KevinRansom KevinRansom requested a review from a team as a code owner June 5, 2023 21:14
@abonie abonie merged commit 50a5b90 into dotnet:main Jun 6, 2023
T-Gro pushed a commit that referenced this pull request Jun 6, 2023
@dotnet-bot @KevinRansom @vzarytovskii
Merge main to release/dev17.7 (#15323)
213f0e1 
* Fix #15313 - The compiler automatically generates an IsReadOnlyAttribute on downlevel frameworks even if we have already defined it. (#15316)


---------

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
@allisonchou allisonchou mentioned this pull request Jun 11, 2023
Closed
@KevinRansom KevinRansom deleted the readonlyattribute branch March 21, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
release/17.7
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
4 participants
@KevinRansom @abonie @T-Gro @vzarytovskii