Fix nuget localization issue #15329
Merged
Fix nuget localization issue #15329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
nugetsourceslocalized
branch
from
ef4bfe8 to
f8b7618
Compare
remove copied comment
abonie
approved these changes
Jun 7, 2023
0101
approved these changes
Jun 7, 2023
majocha
pushed a commit
to majocha/fsharp
that referenced
this pull request
Jun 8, 2023
* Fix nuget localization issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15294 (comment)
In his analysis of this bug @0xBruceLiao identified that the dotnet sdk localise the source enabled/disabled indicator in:
This PR fixes the issue by setting the "DOTNET_CLI_UI_LANGUAGE" to "en-us" when executing this command during packagemanagement.
The image below demonstrates the error in the released fsi, and the fix built with this pr, on a windows localized to French because I did a bit of that at school.