Added Roslyn Completion Service #1534
Conversation
|
Also tagging @dotnet/roslyn-ide to take a look (@CyrusNajmabadi, @jasonmalinowski, @rchande, @mattwar) |
| open Microsoft.FSharp.Compiler.Range | ||
| open Microsoft.FSharp.Compiler.SourceCodeServices | ||
|
|
||
| type internal FSharpCompletionProvider(workspace: Workspace, serviceProvider: SVsServiceProvider) = |
There was a problem hiding this comment.
serviceProvider: SVsServiceProvider [](start = 61, length = 35)
This is sort of a layering violation. Is there no other way to implement this without accessing other VS layer services?
There was a problem hiding this comment.
AFAIK, no, in the existing implementation (see XmlDocumentation.fs). Can you please explain?
There was a problem hiding this comment.
Is the IVsXMLMemberIndexService the only reason for the layer violation? Seems like an abstraction could be added to solve this.
There was a problem hiding this comment.
The general idea for these providers is that they are not dependent on VS, so they can work outside of VS, either to run out of proc or be used within a different host.
There was a problem hiding this comment.
Yes. We can log a future work item for redesigning this.
There was a problem hiding this comment.
Yup. @OmarTawfik and I chatted about that easier. For now, this is VS-only, and we can factor it differently after this goes in.
|
@dotnet-bot test this please |
|
Looks ok to me. |
@Microsoft/visualfsharp
In this PR: