Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FS0052 warnings #1543

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Fix FS0052 warnings #1543

merged 1 commit into from
Sep 20, 2016

Conversation

mrinaldi
Copy link
Contributor

This should fix all the warnings on FSharp.Core.
With this PR, we can up the warning level of FSharp.Core to 5.
Closes #1542.

@msftclas
Copy link

Hi @mrinaldi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@KevinRansom
Copy link
Member

Nice, thank you.

Kevin

@msftclas
Copy link

@mrinaldi, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@KevinRansom KevinRansom merged commit 588ab10 into dotnet:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I just built fsharp.core.dll with warning level 5 and only got these 16 errors
3 participants