Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser recovery for incomplete SynField #15475

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jun 23, 2023

No description provided.

@nojaf nojaf requested a review from a team as a code owner June 23, 2023 07:43
@nojaf nojaf requested a review from auduchinok June 23, 2023 07:43
@auduchinok
Copy link
Member

@nojaf Nice work, but this is already covered in #15042. 🙂

@nojaf
Copy link
Contributor Author

nojaf commented Jun 23, 2023

🙈 I checked your recent PRs but didn't go back that far.

@kerams
Copy link
Contributor

kerams commented Jun 23, 2023

Vlad will send you an invoice for the CI run.

Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge these changes in, I'm going to split #15042 and redo parts of it.

@psfinaki
Copy link
Member

Alright, then @nojaf I guess there are some conflicts to fix here - ping if you need any help with them.

@vzarytovskii vzarytovskii merged commit 02b9e83 into dotnet:main Jun 26, 2023
auduchinok added a commit to auduchinok/fsharp that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants