Real accessibility #15484

KevinRansom · 2023-06-24T09:06:05Z

When the F# compile writes out an assembly, it writes all members with internal and private scopes in the source code as internal. All members of types which are internal are written to the assembly with the IL internal scope. This PR introduces a new compiler switch that preserves the source code annotated scope in the IL.

For example the source code:
Module example:

Class type example:

This change of IL scope impacts the initalization code. Originally intialization required the generation of a type per source file with a .cctor containing all of the initialization code. With real IL signatures this initialization has had to move to a classInitialization method on each class that requires initialization. That is because internal values can be accessed from anywhere inside of the assembly, whereas a private type that is initialized can only happen from a location where that value can be accessed. Ie the class it is specified in and any nested class below it.
In C# the initialization method is the .cctor for that class, unfortunately F# initialization is more structured than C#, C# initialization happens when the type is first used, whereas in F# initialization happens in the order of definition of the values within the source file.

Consider this F# program:

It produces output in this order:

So the initializers need to be invoked with care.

It should also be noted that a type reference can activate any of these types first, and so doing the initialization solely in class constructors would cause the intiialization sequenced to be out of order.

vsintegration/src/FSharp.Editor/LanguageService/Tokenizer.fs

brianrourkeboll · 2024-03-01T16:31:36Z

tests/FSharp.Compiler.ComponentTests/EmittedIL/SeqExpressionStepping/SeqExpressionStepping.fs

@@ -14,47 +14,104 @@ module SeqExpressionStepping =
        |> withNoOptimize
        |> withEmbeddedPdb
        |> withEmbedAllSource
+        |> withRealInternalSignatureOn


Some tests in this file have withRealInternalSignatureOff, but they still then call verifyCompilation, which will add --realsig+ back, no? Did you mean to remove this from here? @KevinRansom

...And wouldn't the alternating tests overwrite each other's baseline files anyway, since there are no separate baseline suffixes specified?

...And wouldn't the alternating tests overwrite each other's baseline files anyway, since there are no separate baseline suffixes specified?

@brianrourkeboll
Let me take a look. TBH --- I am now hating all of the IL baseline tests. Just on a general, "I hate them" basis.

@brianrourkeboll
You are correct I will fix the tests,
thanks
Kevin

@KevinRansom Or I could in my PR (#16650), if that would be easier? Otherwise I'll just have more merge conflicts to resolve lol

I got it, here she blows matey: #16795

@brianrourkeboll , please look it over and I will get it merged.

* Real accessibility (#15484) * merge * remove unused binding * temp * temp * temp * temp * temp * temp * fantomas * temp * temp * quotes * temp * realsig build and test * tuples, staticint tests * SerializableAttribute tests * SeqExpressionStepping * AsyncExpressionStepping * misc * AttributeTargets * CCtorDUWithMember ListExpressionStepping * temp * cleanup * fantomas * temp * temp * temp * Automated command ran: fantomas Co-authored-by: KevinRansom <5175830+KevinRansom@users.noreply.github.com> * Some cleanup * clean * fantoms * temp * merge issues * fantomas * temp * Update src/Compiler/TypedTree/TypedTreeBasics.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * Update src/Compiler/Optimize/Optimizer.fs Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * inline * Fix plain build. * Update changelog * Fixed release notes * feedback * remove surplus realsigs * Update src/Compiler/TypedTree/TypedTree.fsi Co-authored-by: Petr Pokorny <petr@innit.cz> * Update tests/FSharp.Compiler.ComponentTests/EmittedIL/ComputationExpressions/ComputationExpressions.fs Co-authored-by: Petr Pokorny <petr@innit.cz> * baselines * baselines * baselines * build.sh * restore quotes * moar quotes * mutable police * fantomas * t * Update baselines * Shadowing/LinqCount.fsx baseline * Shadowing lingcount * access.fsx --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Petr Pokorny <petr@innit.cz> * Fix range start of INTERP_STRING_PART (#16785) * use the same mechanism we used to fix the range start of INTERP_STRING_END to also fix the range start of INTERP_STRING_PART * - use a new rule for '"}" +' to catch the correct range start - clean up work around structures introduced before and not needed anymore with this * Revert "- use a new rule for '"}" +' to catch the correct range start" This reverts commit 4d01cda. * add second PR to changelog * remove commented poc code * Enforce union case declarations AttributeTargets (#16764) * Enforce union-cases AttributeTargets * release notes * LanguageFeature.EnforceAttributeTargetsUnionCaseDeclarations * release notes * format code * improve naming * Update src/Compiler/Checking/CheckExpressions.fs Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Fix merge conflict --------- Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> * Don't consider parse warnings as errors in ComputeTcIntermediate (#16792) * Fix seqexpression testcases (#16795) * correct realsignature test cases for seqexpr tests * rename typo --------- Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Petr Pokorny <petr@innit.cz> Co-authored-by: dawe <dawedawe@posteo.de> Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: Brian Rourke Boll <brianrourkeboll@users.noreply.github.com> Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>

auduchinok · 2024-03-04T15:15:09Z

The change sounds great!

This PR introduces a new compiler switch that preserves the source code annotated scope in the IL.

Is this going to be a new default one day?

vzarytovskii · 2024-03-04T15:22:28Z

The change sounds great!

This PR introduces a new compiler switch that preserves the source code annotated scope in the IL.

Is this going to be a new default one day?

Maybe one day, if stars align.

auduchinok · 2024-03-04T16:25:39Z

Maybe one day, if stars align.

With so much work done here, it would be sad to have it hidden under a feature flag 🙂
Not enabling it also means we'd have much less real life testing, compared to what the most of the users would use.

vzarytovskii · 2024-03-04T16:38:22Z

Maybe one day, if stars align.

With so much work done here, it would be sad to have it hidden under a feature flag 🙂 Not enabling it also means we'd have much less real life testing, compared to what the most of the users would use.

Sure, as it is with all opt-in features and warnings. It's a huge change in codegen and takes time.

* The test sources and baselines for these were duplicated in dotnet#15484 to test the realsig feature, but that meant that the test _sources_ needed to be kept in sync by hand. This change uses the approach used in dotnet#16795 instead: it reuses the same test _source_ files and just adds duplicate _tests_ to check the emitted IL with realsig+.

* Consolidate emitted IL `for`-loop tests * The test sources and baselines for these were duplicated in #15484 to test the realsig feature, but that meant that the test _sources_ needed to be kept in sync by hand. This change uses the approach used in #16795 instead: it reuses the same test _source_ files and just adds duplicate _tests_ to check the emitted IL with realsig+. * Update netfx baselines * Fix find/replace bug * Unify netstandard assembly version in IL * Re-update baselines --------- Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>

KevinRansom requested a review from a team as a code owner June 24, 2023 09:06

KevinRansom force-pushed the accessibility branch 4 times, most recently from 7b951fc to dd8cd2d Compare July 7, 2023 18:39

KevinRansom force-pushed the accessibility branch 3 times, most recently from cf916e1 to 8b27fdb Compare July 19, 2023 22:46

vzarytovskii marked this pull request as draft July 20, 2023 16:50

KevinRansom force-pushed the accessibility branch 2 times, most recently from 1c07e1e to a5d2be2 Compare July 21, 2023 07:08

KevinRansom force-pushed the accessibility branch 5 times, most recently from 22a4bd2 to e9ed9b9 Compare August 4, 2023 08:34

KevinRansom force-pushed the accessibility branch 6 times, most recently from 23de074 to f714203 Compare August 12, 2023 00:54

KevinRansom force-pushed the accessibility branch 5 times, most recently from 2af1d80 to bbbbd7e Compare August 21, 2023 02:42

KevinRansom force-pushed the accessibility branch 3 times, most recently from f9076e2 to 1b4d64e Compare August 31, 2023 03:23

KevinRansom modified the milestones: January-2024, February-2024 Feb 24, 2024

KevinRansom added 3 commits February 26, 2024 09:49

Merge branch 'main' into accessibility

7258b99

merge

82fbe0e

t

347bb2e

vzarytovskii reviewed Feb 28, 2024

View reviewed changes

vsintegration/src/FSharp.Editor/LanguageService/Tokenizer.fs Show resolved Hide resolved

vzarytovskii approved these changes Feb 28, 2024

View reviewed changes

vzarytovskii and others added 6 commits February 28, 2024 12:59

Merge branch 'main' into accessibility

8eee50e

Update baselines

b2f1973

Merge branch 'main' into accessibility

e1f2c67

Shadowing/LinqCount.fsx baseline

1134abf

Shadowing lingcount

6531478

access.fsx

1523b21

KevinRansom enabled auto-merge (squash) March 1, 2024 03:14

KevinRansom merged commit 68a7dae into dotnet:main Mar 1, 2024
31 checks passed

brianrourkeboll mentioned this pull request Mar 1, 2024

Better integral range lowering: start..finish, start..step..finish #16650

Merged

3 tasks

brianrourkeboll reviewed Mar 1, 2024

View reviewed changes

mthalman mentioned this pull request Mar 4, 2024

Rebootstrap SB SDK/artifacts dotnet/installer#18763

Merged

dotnet-bot mentioned this pull request Mar 12, 2024

[Automated] PRs inserted in VS build main-34712.16 #16864

Closed

KevinRansom deleted the accessibility branch March 21, 2024 22:24

brianrourkeboll mentioned this pull request May 9, 2024

Consolidate emitted IL for-loop tests #17128

Merged

vzarytovskii mentioned this pull request May 16, 2024

FS1118 on inlined function in private module from SDK 8.0.300 #17161

Closed

vzarytovskii mentioned this pull request Jul 3, 2024

Trimmability and compiler optimization regression in FSharp.Core.dll with .NET 8.0.300 SDK #17381

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Real accessibility #15484

Real accessibility #15484

KevinRansom commented Jun 24, 2023 •

edited

Loading

brianrourkeboll Mar 1, 2024

brianrourkeboll Mar 1, 2024

KevinRansom Mar 1, 2024

KevinRansom Mar 1, 2024

brianrourkeboll Mar 1, 2024

KevinRansom Mar 1, 2024

KevinRansom Mar 1, 2024

auduchinok commented Mar 4, 2024

vzarytovskii commented Mar 4, 2024

auduchinok commented Mar 4, 2024

vzarytovskii commented Mar 4, 2024

Real accessibility #15484

Real accessibility #15484

Conversation

KevinRansom commented Jun 24, 2023 • edited Loading

brianrourkeboll Mar 1, 2024

Choose a reason for hiding this comment

brianrourkeboll Mar 1, 2024

Choose a reason for hiding this comment

KevinRansom Mar 1, 2024

Choose a reason for hiding this comment

KevinRansom Mar 1, 2024

Choose a reason for hiding this comment

brianrourkeboll Mar 1, 2024

Choose a reason for hiding this comment

KevinRansom Mar 1, 2024

Choose a reason for hiding this comment

KevinRansom Mar 1, 2024

Choose a reason for hiding this comment

auduchinok commented Mar 4, 2024

vzarytovskii commented Mar 4, 2024

auduchinok commented Mar 4, 2024

vzarytovskii commented Mar 4, 2024

KevinRansom commented Jun 24, 2023 •

edited

Loading