-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest pattern names for union case fields #15530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerams
commented
Jun 30, 2023
Do the following cases still work with this change?
module Nested =
type U =
| A
let (|Id|) x = x
let [<Literal>] Num = 1
open Nested
match None with
| Some({caret}) The same, but without the parens: match None with
| Some {caret} |
All of those items are present. |
It's interesting, given that |
T-Gro
reviewed
Jul 3, 2023
T-Gro
approved these changes
Jul 3, 2023
0101
approved these changes
Jul 3, 2023
kerams
changed the title
Suggest identifier names in patterns
Suggest pattern names for union case fields
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1885.
Names are suggested in match clause, binding and lambda patterns of arbitrary nesting. Functions and values also no longer clutter the completions, since they are not legal in patterns.
The initial high priority of these suggested names does get lost as you start typing though, because VS sorts the list on its own.