Fixing code fixes, part 4 #15551
Merged
Fixing code fixes, part 4 #15551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
commented
Jul 4, 2023
vsintegration/tests/FSharp.Editor.Tests/CodeFixes/UseTripleQuotedInterpolationTests.fs
Show resolved
Hide resolved
0101
approved these changes
Jul 10, 2023
vsintegration/src/FSharp.Editor/CodeFixes/ChangePrefixNegationToInfixSubtraction.fs
Show resolved
Hide resolved
abonie
approved these changes
Jul 10, 2023
T-Gro
reviewed
Jul 11, 2023
|
|
||
| // in a line like "... x -1 ...", | ||
| // squiggly goes for "x", not for "-", hence we search for "-" | ||
| let remainingText = $"{sourceText.GetSubText(context.Span.End)}" |
There was a problem hiding this comment.
$"{}" should never be a replacement for .ToString() in such case.
It's both worse performance wise as well as worse for readability (reader has to stop and figure out why the hell is string interpolation needed here).
There was a problem hiding this comment.
Correction, even worse I guess - the previous code was carefully reading one character at a time from the Roslyn's SourceText.
The new code allocates for the full substring from position till end of the document, even though the algorithm itself only cares about immediate whitespaces after the position.
There was a problem hiding this comment.
Readability is debatable, performance - I guess not. I will fix this in the followup soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: