-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try restore record field completion. #15581
Conversation
Interesting. Let's see if there's any CI failure with this change. |
@auduchinok so WDYT? I trust our tests (in that area) enough to let this in. But generally I wonder what was the reason for the original condition there. |
That change tried to capture both unqualified names from the current environment and record fields. The former provides types, values and other items, but fields aren't allowed to be unqualified, unless inside records (or some special cases, e.g. property initialization in an application). It also seems be about filtering non-fields items for subsequent field completion. There's chance a change like #14821 made that condition not needed (or could be the reason the
Yes, looks good to me! @nojaf has also checked that our tests are green with this change, so it seems good. @nojaf It seems a few parts weren't tested in that PR, could you please check if these cases still work too?
|
Thanks @auduchinok for a detailed answer! Yep, more tests - more good, the suggested scenarios are also worth checking. |
The record fields are no longer completed in
On removal of
when not fieldsOnly
this started working again.I'm not familiar enough with the code to really say if this change is good or not.
@auduchinok this appears to be related to #12872.
Maybe this rings a bell for you.
Running as a draft first to see what CI will say.