Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add F#-specific command line initialization batch file for Dev15 #1567

Merged
merged 1 commit into from
Oct 8, 2016
Merged

add F#-specific command line initialization batch file for Dev15 #1567

merged 1 commit into from
Oct 8, 2016

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Sep 27, 2016

Dev15 packages should now include their own batch file for command line initialization.

The fsharp.bat file simply adds to the %PATH% environment variable. As per internal documentation, if %VSCMD_TEST% has a value, simple smoke testing will occur.

@KevinRansom and @OmarTawfik for review.

@OmarTawfik
Copy link
Contributor

@brettfo are we adding fsc/fsi to PATH? is this script supposed to confirm this functionality?

@brettfo
Copy link
Member Author

brettfo commented Sep 27, 2016

This script adds fsc/fsi to the path and it can verify that it actually worked.

In short, Dev15 components are now responsible for hooking into the VS command prompt on their own and this is now being done by executing all batch files in the Common7\Tools\VsDevCmd\Ext directory. This PR moves the F# file into this repo's packages (I'll send another internal PR that removes the auto-generated one).

@brettfo
Copy link
Member Author

brettfo commented Sep 28, 2016

The appveyor/branch check failed because it was looking for the branch command-prompt on the wrong remote (I'll look into this when I get a chance).

The appveyor/pr check failed due to one FSI test which is unrelated to this change (I'll also look into this when I get a chance).

@brettfo
Copy link
Member Author

brettfo commented Oct 5, 2016

Two issues:

  1. The internal VS build is now appropriately using this copy of fsharp.bat, which means that stuff is fine, but,
  2. The environment variable %FSHARPINSTALLDIR% isn't set, so fsc.exe and fsi.exe aren't on the path. Dev14 does, however, have this variable set.

@OmarTawfik, do you know why the %FSHARPINSTALLDIR% variable isn't getting set during install anymore?

@OmarTawfik
Copy link
Contributor

@brettfo I don't remember having it in our setup. Maybe it was a relic of old Dev14 setup and it was not ported? we can set that in Compiler_Redist.wxs along the lines 113-124 where we are already populating a registery key with that location, or you can use that key.

@brettfo brettfo merged commit d0138b1 into dotnet:master Oct 8, 2016
@brettfo brettfo deleted the command-prompt branch October 8, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants