Move more stuff to cancellable tasks in VS.Editor #15670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run fantomas |
vzarytovskii
commented
Jul 24, 2023
vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Jul 24, 2023
vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Jul 24, 2023
vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs
Outdated
Show resolved
Hide resolved
psfinaki
reviewed
Jul 24, 2023
vsintegration/src/FSharp.Editor/Diagnostics/UnusedOpensDiagnosticAnalyzer.fs
Outdated
Show resolved
Hide resolved
vsintegration/src/FSharp.Editor/Diagnostics/DocumentDiagnosticAnalyzer.fs
Outdated
Show resolved
Hide resolved
vzarytovskii
force-pushed
the
more-cancellable-tasks2
branch
from
9b8bd99 to
2452adc
Compare
psfinaki
approved these changes
Jul 24, 2023
0101
approved these changes
Jul 24, 2023
T-Gro
approved these changes
Jul 25, 2023
|
VSIX built from this branch: https://1drv.ms/u/s!AiT31MwroM_3lfUYVfV8H3l14MZfpg?e=O982p6 |
psfinaki
reviewed
Aug 2, 2023
psfinaki
reviewed
Aug 2, 2023
psfinaki
reviewed
Aug 2, 2023
psfinaki
reviewed
Aug 2, 2023
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
|
/run fantomas |
Co-authored-by: vzarytovskii <1260985+vzarytovskii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From personal tests (not super accurate, since was running and profilind devenv under devenv), colouring and completions are somewhere between 1% and 5% snappier (due to changes to classification), allocations are better - 4.4Gb -> 3.5Gb on VisualFSharp.sln with the same set of documents open + typechecked from the "cold" start.