-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler tests cleanup, part 1 #15690
Conversation
@auduchinok @nojaf could you please take a look at it, if it works for you guys. I don't think that UnitTests are in the FCS solution, so it's pretty much removing tests from this solution. |
Removing the tests project from FCS solution would be really problematic, as we mostly work with this solution. Would it be possible to add |
Uff that would be even harder - because FSharp.Compiler.Service.Tests is NUnit whereas we are converging things to xUnit, hence to FSharp.Compiler.UnitTests which is xUnit already. How about including both projects in the FCS solution until we eventually only have one? |
@psfinaki , hey mate, at first I was wondering why you wasn't merging unit tests into compiler service, because xunit has fewer files. But I suppose the xunit translation may take a moment. Anyway two thumbs for this, I like the goal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both suites should be in the service solution.
Done |
Project was added to Fsharp.Compiler.Service.sln
This will be quite a journey.
The idea is to merge FSharp.Compiler.Service.Tests with FSharp.Compiler.UnitTests and move to xUnit altogether.
This will also remove some test duplication and save some CI time.