Remove need for passed in "ArcadeSdk" variable in source build #15834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a passed in variable to determine where arcade lives, use a similar strategy of a few other repos (deployment tools, runtime, diagnostics) of using the parent directory of the tasks assembly, which is a property always available. This can then be used to find the release packages targets. Avoids the need to pass in the arcade SDK location as an env variable for FSharp.
|
Eliminates the need for this https://github.com/dotnet/installer/blob/main/src/SourceBuild/content/repo-projects/fsharp.proj#L25-L30 source-build logic |
T-Gro
approved these changes
Aug 22, 2023
vzarytovskii
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a passed in variable to determine where arcade lives, use a similar strategy of a few other repos (deployment tools, runtime, diagnostics) of using the parent directory of the tasks assembly, which is a property always available. This can then be used to find the release packages targets. Avoids the need to pass in the arcade SDK location as an env variable for FSharp.