Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting for duplicated fields anonymous record expressions #15836

Conversation

edgarfgp
Copy link
Contributor

Continuation of #15824

@edgarfgp edgarfgp requested a review from a team as a code owner August 22, 2023 09:05
@T-Gro
Copy link
Member

T-Gro commented Aug 22, 2023

Does the behavior affect also:

  • with copy-and-update syntax ?
  • anonymous records used in type annotations ?

What I am unsure after this change is whether there is a situation in which an error would be doubled.

@edgarfgp
Copy link
Contributor Author

  • with copy-and-update syntax ?

It won't affect the with copy-and-update syntax we are still using error so we won't cascade errors (See the tests for more info)

  • What I am unsure of after this change is whether there is a situation in which an error would be doubled.

I double-checked with the CopyAndUpdateTests and it seems fine to me

@edgarfgp edgarfgp requested a review from T-Gro August 23, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants