Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize pattern compilation #15839

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Optimize pattern compilation #15839

merged 2 commits into from
Aug 23, 2023

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Aug 22, 2023

The improvement is twofold:

  • Rule ranges are not computed until we know we're reporting an unused rule warning.
  • Trivial pattern matches, typical in bindings - let x = 0, exit early and avoid some allocations.

@kerams kerams requested a review from a team as a code owner August 22, 2023 16:46
@edgarfgp
Copy link
Contributor

Awesome. Thanks for improving this :)

@T-Gro T-Gro merged commit 022d0d0 into dotnet:main Aug 23, 2023
@kerams kerams deleted the p branch August 23, 2023 10:26
@allisonchou allisonchou mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kerams @edgarfgp @vzarytovskii @T-Gro