Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the FSHARPINSTALLDIR variable system-wide, but don't overwrite it if it's already present #1586

Merged
merged 1 commit into from
Oct 29, 2016
Merged

make the FSHARPINSTALLDIR variable system-wide, but don't overwrite it if it's already present #1586

merged 1 commit into from
Oct 29, 2016

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Oct 8, 2016

@OmarTawfik
Copy link
Contributor

Why not overwriting it? The user should only have one instance of that MSI installed. If the key wasn't cleared from a previous installation, it should be overwritten?

@KevinRansom
Copy link
Member

@brettfo What was the behavior in vs2015?

@KevinRansom KevinRansom merged commit 4c93b84 into dotnet:master Oct 29, 2016
@brettfo brettfo deleted the command-prompt branch January 9, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brettfo @OmarTawfik @KevinRansom @msftclas