Deduplicate and sort error codes

azure-pipelines.yml

@@ -249,7 +249,7 @@ stages:
             continueOnError: true
             condition: not(succeeded())
 
-          # Check code formatting
+          # Check FSComp.txt error code sorting code formatting
         - job: CheckCodeFormatting
           pool:
             vmImage: $(UbuntuMachineQueueName)
@@ -270,6 +270,10 @@ stages:
             env:
               DOTNET_ROLL_FORWARD_TO_PRERELEASE: 1
             displayName: Install tools
+          - script: dotnet fsi src/Compiler/FSCompCheck.fsx
+            env:
+              DOTNET_ROLL_FORWARD_TO_PRERELEASE: 1
+            displayName: Check error code sorting in src/Compiler/FSComp.txt
           - script: dotnet fantomas . -r --check
             env:
               DOTNET_ROLL_FORWARD_TO_PRERELEASE: 1

src/Compiler/FSComp.txt

@@ -201,10 +201,10 @@ ExceptionDefsNotCompatibleFieldOrderDiffers,"The exception definitions are not c
 363,typrelNeedExplicitImplementation,"The interface '%s' is included in multiple explicitly implemented interface types. Add an explicit implementation of this interface."
 364,typrelNamedArgumentHasBeenAssignedMoreThenOnce,"The named argument '%s' has been assigned more than one value"
 365,typrelNoImplementationGiven,"No implementation was given for '%s'"
-366,typrelNoImplementationGivenWithSuggestion,"No implementation was given for '%s'. Note that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'."
 365,typrelNoImplementationGivenSeveral,"No implementation was given for those members: %s"
-366,typrelNoImplementationGivenSeveralWithSuggestion,"No implementation was given for those members: %sNote that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'."
 365,typrelNoImplementationGivenSeveralTruncated,"No implementation was given for those members (some results omitted): %s"
+366,typrelNoImplementationGivenWithSuggestion,"No implementation was given for '%s'. Note that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'."
+366,typrelNoImplementationGivenSeveralWithSuggestion,"No implementation was given for those members: %sNote that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'."
 366,typrelNoImplementationGivenSeveralTruncatedWithSuggestion,"No implementation was given for those members (some results omitted): %sNote that all interface members must be implemented and listed under an appropriate 'interface' declaration, e.g. 'interface ... with member ...'."
 367,typrelMemberDoesNotHaveCorrectNumberOfArguments,"The member '%s' does not have the correct number of arguments. The required signature is '%s'."
 368,typrelMemberDoesNotHaveCorrectNumberOfTypeParameters,"The member '%s' does not have the correct number of method type parameters. The required signature is '%s'."
@@ -908,9 +908,6 @@ optsStaticlink,"Statically link the given assembly and all referenced DLLs that
 optsResident,"Use a resident background compilation service to improve compiler startup times."
 optsPdb,"Name the output debug file"
 optsSimpleresolution,"Resolve assembly references using directory-based rules rather than MSBuild resolution"
-1048,optsUnrecognizedTarget,"Unrecognized target '%s', expected 'exe', 'winexe', 'library' or 'module'"
-1049,optsUnrecognizedDebugType,"Unrecognized debug type '%s', expected 'pdbonly' or 'full'"
-1050,optsInvalidWarningLevel,"Invalid warning level '%d'"
 optsShortFormOf,"Short form of '%s'"
 optsClirootDeprecatedMsg,"The command-line option '--cliroot' has been deprecated. Use an explicit reference to a specific copy of mscorlib.dll instead."
 optsClirootDescription,"Use to override where the compiler looks for mscorlib.dll and framework components"
@@ -937,6 +934,9 @@ optsSignatureData,"Include F# interface information, the default is file. Essent
 1046,optsUnknownSignatureData,"Invalid value '%s' for --interfacedata, valid value are: none, file, compress."
 optsOptimizationData,"Specify included optimization information, the default is file. Important for distributed libraries."
 1047,optsUnknownOptimizationData,"Invalid value '%s' for --optimizationdata, valid value are: none, file, compress."
+1048,optsUnrecognizedTarget,"Unrecognized target '%s', expected 'exe', 'winexe', 'library' or 'module'"
+1049,optsUnrecognizedDebugType,"Unrecognized debug type '%s', expected 'pdbonly' or 'full'"
+1050,optsInvalidWarningLevel,"Invalid warning level '%d'"
 1051,optsInvalidSubSystemVersion,"Invalid version '%s' for '--subsystemversion'. The version must be 4.00 or greater."
 1052,optsInvalidTargetProfile,"Invalid value '%s' for '--targetprofile', valid values are 'mscorlib', 'netcore' or 'netstandard'."
 1063,optsUnknownArgumentToTheTestSwitch,"Unknown --test argument: '%s'"

src/Compiler/FSCompCheck.fsx

@@ -0,0 +1,22 @@
+#r "nuget: FSharpPlus, 1.4.1"
+let inline (|Matches|_|) format = FSharpPlus.Parsing.trySscanf format
+
+__SOURCE_DIRECTORY__ + "/FSComp.txt"
+|> System.IO.File.ReadAllLines
+|> Seq.fold
+    (fun counters line ->
+        match line with
+        | Matches "%d,%s" (errorCode, _)
+        | Matches "#%d %s" (errorCode, _)
+        | Matches "#%d,%s" (errorCode, _) ->
+            match counters with
+            | [] -> [ errorCode ] // Initialise a counter
+            | head :: tail when errorCode >= head -> errorCode :: tail // Increment current counter
+            | _ -> errorCode :: counters // Start a new counter
+        | _ -> counters)
+    []
+|> function
+    | [] -> failwith "FSComp.txt contained no error codes but expected at least one"
+    | [ _finalErrorCode ] -> () // Expected: One counter counted to the end
+    | _finalErrorCode :: counters ->
+        failwith $"Error codes not sorted in FSComp.txt, breaks happened after {List.rev counters}"