-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental build: catch exception during file checking #15906
Conversation
Hmm, wonder if we could somehow report the exception... |
Ideally, the initial exception should be reported in #15907 when it's actually recovered and not rethrown. But, yeah, we should probably report it when it gets here somehow. I'd rather keep it out of scope of this PR, so we only fix the crash here, and it's easier to cherry-pick or revert it independently of other changes. |
Any way to test this? |
An alternate solution I'd propose would be to ban (We have a very few of its existing usages anyway.) Just replace it with |
We want to eventually move to cancellable tasks outside of public APIs, as they shown to be quite effective in VS extension, which should solve the exceptions problem. |
That also sounds like a good solution 👍 |
Partially fixes #15905. Prevents the crash of the host process. Catches exception happening during a file analysis, preventing the host process crash. With this fix analysis of subsequent files don't work, but this prevents the crash and allows to fix the source code when it's the reason of the initial exception.