Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VisitValSig to SyntaxVisitorBase. #15930

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Add VisitValSig to SyntaxVisitorBase. #15930

merged 4 commits into from
Sep 6, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 5, 2023

I want to expand the SyntaxVisitorBase to be able to traverse signature files as well.
I'm no expert in this, nor do I claim to grasp all the details here.
I looked at how SynBinding works and tried to mimic it for SynValSig.

@nojaf nojaf requested a review from a team as a code owner September 5, 2023 15:40
@T-Gro T-Gro enabled auto-merge (squash) September 6, 2023 09:29
@T-Gro T-Gro merged commit 41b6ed7 into dotnet:main Sep 6, 2023
@nojaf nojaf mentioned this pull request Sep 7, 2023
Merged
@allisonchou allisonchou mentioned this pull request Sep 7, 2023
Closed
@nojaf nojaf mentioned this pull request Oct 5, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @vzarytovskii @T-Gro