-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IL: optimize attribute cluster reading (Fixed version) #15941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DedSec256 Thanks!
Would it be possible to write a test that references |
This will probably have to go past net8, just to be safe |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@DedSec256 hey Alex, this LGTM, if possible please add a test described by Eugene, then we can probably pull this in. |
@psfinaki, I tried to add a test, but it requires the specific version of System.Runtime.CompilerServices.Unsafe.dll (Metadata v4.0.30319) on which the problem is known to reproduce. So we need to push this version of the library, or come up with something else. |
Just have a separate manual test under |
Sorry, I tried to reproduce it yesterday and today, but for some reason I couldn't. The fix from 1e0ebe5 fsharp/src/Compiler/AbstractIL/ilread.fs Line 1291 in 1e0ebe5
seems obvious, maybe is it possible to merge this as is? |
Just to be clear, the change compared to previous revision is an off-by-one fix? |
Yes, the current version differs from the previous one by only one commit 1e0ebe5 that has two changes:
|
Fixed version of #13821
This PR contains fix 1e0ebe5 for the loop counter that previously caused seek to hang in an unsorted table #14651.
Search in a sorted table is also slightly refactored to be more clear.
Without this fix, the hang reproduced at build time and in the IDE while analyzing file
SplitApp.Android/MainActivity.fs
from the issue above, when trying to read attributes for assemblySystem.Runtime.CompilerServices.Unsafe.dll (Metadata v4.0.30319)
.cc @auduchinok