Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: report error on missing first item in tuple expressions #15999

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Parser: report error on missing first item in tuple expressions #15999

merged 2 commits into from
Sep 20, 2023

Conversation

auduchinok
Copy link
Member

Fixes #15955.

@auduchinok auduchinok requested a review from a team as a code owner September 19, 2023 11:52
@auduchinok auduchinok closed this Sep 19, 2023
@auduchinok auduchinok reopened this Sep 19, 2023
@vzarytovskii
Copy link
Member

Shall we add the test it was reproduced on?

@auduchinok
Copy link
Member Author

The syntax tests show the errors now, I think it should be enough.

@vzarytovskii vzarytovskii merged commit 6d1d1d9 into dotnet:main Sep 20, 2023
@auduchinok auduchinok deleted the parser-expr-tupleComma branch September 20, 2023 06:18
@allisonchou allisonchou mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing argument compiles without error and throws CLR error during runtime
4 participants
@auduchinok @vzarytovskii @psfinaki @abonie