Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup output paths when building with shipped .NET #16022

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fixup output paths when building with shipped .NET #16022

merged 1 commit into from
Sep 22, 2023

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Sep 22, 2023 •
edited
Loading

This will fix VSCode test explorer discovering tests...hopefully.

@vzarytovskii vzarytovskii requested a review from a team as a code owner September 22, 2023 12:56
@vzarytovskii vzarytovskii enabled auto-merge (squash) September 22, 2023 13:06
psfinaki
psfinaki approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be awesome! How exactly does this help actually?

@vzarytovskii vzarytovskii merged commit 15331e0 into dotnet:main Sep 22, 2023
@vzarytovskii
Copy link
Member Author

That would be awesome! How exactly does this help actually?

Sets the $(Configuration), so the output path for assmbly is correct

@allisonchou allisonchou mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abonie abonie abonie approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vzarytovskii @psfinaki @abonie