Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow intrinsic extensions for static members in interfaces #16157

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Allow intrinsic extensions for static members in interfaces #16157

merged 2 commits into from
Oct 23, 2023

Conversation

gusty
Copy link
Contributor

@gusty gusty commented Oct 23, 2023

Fixes #15990

@gusty gusty changed the title Remove limitation Allow intrinsic extensions for static methods in interfaces Oct 23, 2023
@gusty gusty changed the title Allow intrinsic extensions for static methods in interfaces Allow intrinsic extensions for static members in interfaces Oct 23, 2023
@gusty gusty marked this pull request as ready for review October 23, 2023 08:58
@gusty gusty requested a review from a team as a code owner October 23, 2023 08:58
@T-Gro T-Gro enabled auto-merge (squash) October 23, 2023 09:01
psfinaki
psfinaki approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks!

@T-Gro T-Gro merged commit bd66d54 into dotnet:main Oct 23, 2023
24 checks passed
auduchinok pushed a commit to auduchinok/fsharp that referenced this pull request Oct 23, 2023
@gusty @auduchinok
Allow intrinsic extensions for static members in interfaces (dotnet#1…
69cb2fb 
…6157)

Allow intrinsic extensions for static members in interfaces
@gusty gusty mentioned this pull request Nov 2, 2023
Open
@allisonchou allisonchou mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@abonie abonie abonie approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intrinsic extensions for static methods in interfaces fail to compile
4 participants
@gusty @psfinaki @abonie @T-Gro