Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker: fix options equality for il module reader references #16161

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

auduchinok
Copy link
Member

Fixes project options weren't considered equal when 1) project references contain il module readers and 2) no project stamp is set. Il module readers are currently only used in Rider, but Rider also sets project stamp in project options, so we didn't see this behaviour before. I've noticed this behaviour in tests that use these readers but don't set the stamp.

@auduchinok auduchinok requested a review from a team as a code owner October 23, 2023 17:16
@T-Gro T-Gro enabled auto-merge (squash) October 24, 2023 10:08
@T-Gro T-Gro merged commit f88d5d4 into dotnet:main Oct 24, 2023
24 checks passed
@auduchinok auduchinok deleted the checker-options-areSame-readers branch October 24, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants