Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Live Buffers by default in VS #16176

Merged
merged 1 commit into from
Oct 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.Editor/FSharp.Editor.resx
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ Display inline type hints (preview);
Display return type hints (preview);
Display inline parameter name hints (preview);
Live Buffers;
Use live (unsaved) buffers for checking</value>
Use live (unsaved) buffers for analysis</value>
</data>
<data name="6014" xml:space="preserve">
<value>Formatting</value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ type internal FSharpWorkspaceServiceFactory [<Composition.ImportingConstructor>]
let enableParallelReferenceResolution =
editorOptions.LanguageServicePerformance.EnableParallelReferenceResolution

let enableLiveBuffers = editorOptions.Advanced.IsLiveBuffersEnabled
let enableLiveBuffers = editorOptions.Advanced.IsUseLiveBuffersEnabled

let useSyntaxTreeCache = editorOptions.LanguageServicePerformance.UseSyntaxTreeCache

Expand Down
4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/Options/EditorOptions.fs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ type AdvancedOptions =
IsInlineTypeHintsEnabled: bool
IsInlineParameterNameHintsEnabled: bool
IsInlineReturnTypeHintsEnabled: bool
IsLiveBuffersEnabled: bool
IsUseLiveBuffersEnabled: bool
SendAdditionalTelemetry: bool
SolutionBackgroundAnalysis: bool
}
Expand All @@ -124,7 +124,7 @@ type AdvancedOptions =
IsInlineTypeHintsEnabled = false
IsInlineParameterNameHintsEnabled = false
IsInlineReturnTypeHintsEnabled = false
IsLiveBuffersEnabled = FSharpExperimentalFeaturesEnabledAutomatically
IsUseLiveBuffersEnabled = true
SendAdditionalTelemetry = true
SolutionBackgroundAnalysis = false
}
Expand Down
4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
</StackPanel>
</GroupBox>
<GroupBox Header="{x:Static local:Strings.LiveBuffers}">
<CheckBox x:Name="toggleLiveBuffers" IsChecked="{Binding IsLiveBuffersEnabled}"
<CheckBox x:Name="toggleLiveBuffers" IsChecked="{Binding IsUseLiveBuffersEnabled}"
Content="{x:Static local:Strings.Enable_Live_Buffers}"/>
</GroupBox>
<GroupBox Header="{x:Static local:Strings.AdditionalTelemetry}">
Expand Down
4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.UIResources/Strings.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.UIResources/Strings.resx
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,10 @@
<value>Keep background symbol keys</value>
</data>
<data name="Enable_Live_Buffers" xml:space="preserve">
<value>Use live (unsaved) buffers for checking (restart required)</value>
<value>Use live (unsaved) buffers for analysis (restart required)</value>
</data>
<data name="LiveBuffers" xml:space="preserve">
<value>Live Buffers (experimental)</value>
<value>Live Buffers</value>
</data>
<data name="AdditionalTelemetry" xml:space="preserve">
<value>Additional performance telemetry (experimental)</value>
Expand Down
13 changes: 4 additions & 9 deletions vsintegration/src/FSharp.UIResources/xlf/Strings.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions vsintegration/src/FSharp.UIResources/xlf/Strings.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions vsintegration/src/FSharp.UIResources/xlf/Strings.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions vsintegration/src/FSharp.UIResources/xlf/Strings.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions vsintegration/src/FSharp.UIResources/xlf/Strings.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading