Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address hard wrapped comments in infer_struct #16188

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Oct 26, 2023

per #16186 (reply in thread)

note that I'm not touching line 11 in the second file because it isn't poorly wrapped and I don't want to shift line/col references.

I'm flexible and if people would prefer to drop the lines entirely, I can do this.

@jsoref jsoref requested a review from a team as a code owner October 26, 2023 13:28
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki psfinaki enabled auto-merge (squash) October 26, 2023 14:20
@psfinaki psfinaki merged commit a7e5e26 into dotnet:main Oct 26, 2023
24 checks passed
@jsoref jsoref deleted the disc-16186 branch October 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants