Fix: generate fixups for static abstracts #16195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/generate-fixups-for-statics
branch
5 times, most recently
from
62cee36 to
c04a142
Compare
gusty
force-pushed
the
gus/generate-fixups-for-statics
branch
from
68e920c to
cbcbf5c
Compare
|
Do you think it's worth it to add tests for INumber<_>, which @En3Tho suggested in the previous PR? These will cover some standard bcl stuff. |
|
I think it's worth covering some BCL stuff. I will add more tests. |
T-Gro
approved these changes
Oct 30, 2023
|
(worth backporting to release branch, wdyt?) |
Probably not, we are way past the cutoff date. At this time, I think, only fixes for big regressions are getting considered. |
vzarytovskii
approved these changes
Oct 30, 2023
|
@vzarytovskii @gusty Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15919 and #14595 when inheriting a static abstract in another interface.