-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for underscore dot lambda: Forbidding expressions not based on the implied _ arg #16207
Merged
psfinaki
merged 9 commits into
dotnet:main
from
T-Gro:16136-expressions-other-than-propertiesmethod-callsindexing-are-allowed-after-_-in-dot-lambdas
Nov 1, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-callsindexing-are-allowed-after-_-in-dot-lambdas
abonie
approved these changes
Oct 31, 2023
Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
edgarfgp
approved these changes
Oct 31, 2023
psfinaki
changed the title
Bufix for underscore dot lambda: Forbidding expressions not based on the implied _ arg
Bugfix for underscore dot lambda: Forbidding expressions not based on the implied _ arg
Oct 31, 2023
…d-callsindexing-are-allowed-after-_-in-dot-lambdas
…xing-are-allowed-after-_-in-dot-lambdas' of https://github.com/T-Gro/fsharp into 16136-expressions-other-than-propertiesmethod-callsindexing-are-allowed-after-_-in-dot-lambdas
psfinaki
approved these changes
Nov 1, 2023
T-Gro
deleted the
16136-expressions-other-than-propertiesmethod-callsindexing-are-allowed-after-_-in-dot-lambdas
branch
November 1, 2023 12:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16136 .
Although some of them look interesting, they should not be a hidden part of this feature, and all of them will now report an error:
This used to work in the release candidate by mistake, and will be a hard error.
(explanation: Those were all expressions, which did not make use of the implied argument to the lambda.
It produced a lambda function working on any kind of generic argument 'a, which always returned the same constant value)