VS checkbox for controlling the "Remove parens" diag+fix #16211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Nov 1, 2023
abonie
approved these changes
Nov 1, 2023
brianrourkeboll
added a commit
to brianrourkeboll/roslyn
that referenced
this pull request
Sep 7, 2024
* For background, see: * dotnet#35591 * dotnet/fsharp#16078, * dotnet/fsharp#16079 (comment) * dotnet/fsharp#16079 (review) * dotnet/fsharp#16211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the RemoveParens diagnostic is hardcoded into the call for getting syntax diagnostics.
That happens with every keystroke and powers many basic features.
Like with other analyzers, this PR adds the checkbox to control it, with the default value of "false".
Once this analyzer has its own call from Roslyn, default can be changed to "true".