Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 15958: Missing warning FS3365 for SynLongIdent (dotless indexing vs application) #16224

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Nov 3, 2023

This tries to fix #15958

Although people are warming up to move new warnings to analyzers, I think this is still good to have in the compiler as it's related to a syntax change (dotless indexing).

@dawedawe dawedawe requested a review from a team as a code owner November 3, 2023 17:30
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dawe!

@psfinaki psfinaki merged commit a1ecaa1 into dotnet:main Nov 6, 2023
24 checks passed
@dawedawe dawedawe deleted the fix-15958 branch November 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing warning FS3365 for SynLongIdent
4 participants