Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal error when implementing IWSAM in object expression #16250

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Fix internal error when implementing IWSAM in object expression #16250

merged 7 commits into from
Nov 14, 2023

Conversation

edgarfgp
Copy link
Contributor

Fixes #16213
Follow-up: #16175

@edgarfgp edgarfgp changed the title Fix internal error when implements IWSAM in object expression Fix internal error when implementing IWSAM in object expression Nov 10, 2023
@edgarfgp edgarfgp marked this pull request as ready for review November 10, 2023 13:02
@edgarfgp edgarfgp requested a review from a team as a code owner November 10, 2023 13:02
@edgarfgp edgarfgp closed this Nov 12, 2023
@edgarfgp edgarfgp reopened this Nov 12, 2023
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Nov 13, 2023 •
edited
Loading

Triggering the CI again.

@edgarfgp edgarfgp closed this Nov 13, 2023
@edgarfgp edgarfgp reopened this Nov 13, 2023
@psfinaki
Copy link
Member

/azp ru

@azure-pipelines Azure Pipelines
Copy link

Command 'ru' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@edgarfgp
Copy link
Contributor Author

Thanks @psfinaki for running the CI. Looks like WindowsCompressedMetadata coreclr_release started to fail and looking the stack trace The active test run was aborted. Reason: Test host process crashed : Fatal error. Internal CLR error. (0x80131506). Not sure if is related to this my changes.

@edgarfgp
Copy link
Contributor Author

This is ready.

@vzarytovskii
Copy link
Member

Nice, thanks.

psfinaki
psfinaki approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psfinaki psfinaki merged commit d2af754 into dotnet:main Nov 14, 2023
@edgarfgp edgarfgp mentioned this pull request Nov 14, 2023
Merged
@allisonchou allisonchou mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoothdeveloper smoothdeveloper smoothdeveloper left review comments

@0101 0101 0101 left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object expressions don't work with IWSAMs
5 participants
@edgarfgp @psfinaki @vzarytovskii @smoothdeveloper @0101