Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp disable flaky tests #16284

Closed
wants to merge 1 commit into from
Closed

Temp disable flaky tests #16284

wants to merge 1 commit into from

Conversation

psfinaki
Copy link
Member

No description provided.

@psfinaki psfinaki requested a review from a team as a code owner November 15, 2023 16:47
@psfinaki psfinaki enabled auto-merge (squash) November 15, 2023 16:48
@brianrourkeboll
Copy link
Contributor

brianrourkeboll commented Nov 15, 2023

I see what it is: 4c36a98 from #16262 makes that test case hit this:

| SynExpr.Sequential(expr1 = SynExpr.Paren(expr = Is inner)), Dangling.Problematic _ -> ValueNone

That should really only be if expr1 and expr2 are on the same line. I'll update that.

Funny, the only way that got into main is because #16262 was merged before #16248; the test would have failed in CI if they'd been merged in the other order 🙃

@brianrourkeboll
Copy link
Contributor

#16285

@T-Gro
Copy link
Member

T-Gro commented Nov 15, 2023

Let's get the fix into main instead and close this PR.

@psfinaki psfinaki disabled auto-merge November 15, 2023 18:21
@psfinaki psfinaki closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants