Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service: wrap creating reference from module reader into cancellable #16338

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Service: wrap creating reference from module reader into cancellable #16338

merged 1 commit into from
Nov 27, 2023

Conversation

auduchinok
Copy link
Member

Fixes the initial processing of FSharpReferencedProject.ILModuleReference wasn't wrapped into cancellable, making it non-cancellable via Cancellable.CheckAndThrow. The similar code processing FSharpReferencedProject.PEReference was already wrapped correctly, so it's only ILModuleReference that had this issue. The fix uses cancellable computation instead of plain node.

@auduchinok auduchinok requested a review from a team as a code owner November 24, 2023 12:32
@T-Gro T-Gro merged commit b044ca9 into dotnet:main Nov 27, 2023
25 checks passed
@allisonchou allisonchou mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auduchinok @vzarytovskii @psfinaki @T-Gro