Bugfix for 16330: Error while using [<TailCall>] #16347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use GetValReprTypeInFSharpForm instead of GetTopTauTypeInFSharpForm - fixes dotnet#16330 - add regression tests
dawedawe
changed the title
T-Gro
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16330
I introduced a bug when I ported PR #1976 to the current code base.
To get the
currietArgInfosI should have calledGetValReprTypeInFSharpForm, not GetTopTauTypeInFSharpForm.The bug is an effect of feeding the wrong
tauintoGetTopTauTypeInFSharpForm.It's wrong because I used
destTopForallTyonfty, which results in unequal lengths ofnArgInfosargTysinside ofGetTopTauTypeInFSharpFormBy using
GetValReprTypeInFSharpFormthe correct args are passed todestTopForallTyandnArgInfosandargTys.Lengthare of equal length.I also added two regression tests.