Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing some dead benchmark material #16458

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Removing some dead benchmark material #16458

merged 1 commit into from
Jan 2, 2024

Conversation

psfinaki
Copy link
Member

Description

This deletes some of the files added very long ago during the work on tasks in this PR. They were useful at that time, but not useful and usable anymore.

  • TaskPerfPreviousCompiler is broken and that particular compiler comparison is not applicable or needed anymore. If we want to do any cross-version F# functionality comparison, we should use the approach used in the BenchmarkComparison project
  • The BDN markdown file was most likely checked in accidentally and contains intermediary results (roughly 2 months before PR merge, never updated ever again). BDN results are generated locally and git-ignored now.

Checklist

  • Test cases removed
  • Performance benchmarks removed in case of performance changes

@psfinaki psfinaki requested a review from a team as a code owner December 20, 2023 21:51
@psfinaki psfinaki enabled auto-merge (squash) December 21, 2023 11:14
@psfinaki psfinaki merged commit d1ce3ec into main Jan 2, 2024
26 checks passed
@psfinaki psfinaki deleted the bench/1 branch January 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants