Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parens API #16461

Merged
merged 14 commits into from
Jan 22, 2024
Merged

Refactor parens API #16461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
38ba838
Refactor parens API
brianrourkeboll Dec 20, 2023
7cf3bd8
Fantomas
brianrourkeboll Dec 21, 2023
473ce03
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Dec 21, 2023
a1c5b90
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Jan 19, 2024
07fc67f
Use `ParsedInput.fold`
brianrourkeboll Jan 19, 2024
b227533
Tests
brianrourkeboll Jan 19, 2024
692ebf4
Update surface area
brianrourkeboll Jan 19, 2024
ef4bc46
Clean up sigs & comments
brianrourkeboll Jan 19, 2024
b22fc9f
Update release notes
brianrourkeboll Jan 19, 2024
282ea71
Remove redundant async
brianrourkeboll Jan 19, 2024
6a1fc9f
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Jan 22, 2024
bd7908e
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Jan 22, 2024
c1a7ae5
Merge main
brianrourkeboll Jan 22, 2024
cbb92d9
Remove stubs (no longer needed)
brianrourkeboll Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions docs/fcs/untypedtree-apis.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,6 @@ let isPosInTypeDefn' = // Still true.
*)

(*** hide ***)

module SynExpr =
let shouldBeParenthesizedInContext (getLineStr: int -> string) (path: SyntaxVisitorPath) (expr: SynExpr) : bool = failwith "Nope."

module SynPat =
let shouldBeParenthesizedInContext (path: SyntaxVisitorPath) (pat: SynPat) : bool = failwith "Nope."

let getLineStr (line: int) : string = failwith "Nope."

(**
Expand Down
3 changes: 2 additions & 1 deletion docs/release-notes/.FSharp.Compiler.Service/8.0.300.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@
* `implicitCtorSynPats` in `SynTypeDefnSimpleRepr.General` is now `SynPat option` instead of `SynSimplePats option`. ([PR #16425](https://github.com/dotnet/fsharp/pull/16425))
* `SyntaxVisitorBase<'T>.VisitSimplePats` now takes `SynPat` instead of `SynSimplePat list`. ([PR #16425](https://github.com/dotnet/fsharp/pull/16425))
* Reduce allocations in compiler checking via `ValueOption` usage ([PR #16323](https://github.com/dotnet/fsharp/pull/16323))
* Reverted [#16348](https://github.com/dotnet/fsharp/pull/16348) `ThreadStatic` `CancellationToken` changes to improve test stability and prevent potential unwanted cancellations. ([PR #16536](https://github.com/dotnet/fsharp/pull/16536))
* Reverted [#16348](https://github.com/dotnet/fsharp/pull/16348) `ThreadStatic` `CancellationToken` changes to improve test stability and prevent potential unwanted cancellations. ([PR #16536](https://github.com/dotnet/fsharp/pull/16536))
* Refactored parenthesization API. ([PR #16461])(https://github.com/dotnet/fsharp/pull/16461))
4 changes: 4 additions & 0 deletions docs/release-notes/.VisualStudio/17.10.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### Fixed

* Show signature help mid-pipeline in more scenarios. ([PR #16462](https://github.com/dotnet/fsharp/pull/16462))

### Changed

* Use refactored parenthesization API in unnecessary parentheses code fix. ([PR #16461])(https://github.com/dotnet/fsharp/pull/16461))
4 changes: 4 additions & 0 deletions src/Compiler/FSharp.Compiler.Service.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,10 @@
<Compile Include="Service\ServiceLexing.fs" />
<Compile Include="Service\ServiceParseTreeWalk.fsi" />
<Compile Include="Service\ServiceParseTreeWalk.fs" />
<Compile Include="Service\SynExpr.fsi" />
<Compile Include="Service\SynExpr.fs" />
<Compile Include="Service\SynPat.fsi" />
<Compile Include="Service\SynPat.fs" />
<Compile Include="Service\ServiceNavigation.fsi" />
<Compile Include="Service\ServiceNavigation.fs" />
<Compile Include="Service\ServiceParamInfoLocations.fsi" />
Expand Down
Loading
Loading