Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format CheckComputationExpressions.fs #16512

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 11, 2024

Description

There is some renewed interest in looking into #14429.
As a first cosmetic step, I'd like to format this file so diffs will be easier to deal with when collaborating with multiple contributors.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner January 11, 2024 14:02
@nojaf nojaf added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 11, 2024
Copy link
Contributor

github-actions bot commented Jan 11, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii
Copy link
Member

Could you please also add commit to .git-blame-ignore-revs file (needs to be created), so we don't see it in blame?

@nojaf nojaf closed this Jan 12, 2024
@nojaf nojaf reopened this Jan 12, 2024
@vzarytovskii
Copy link
Member

@dotnet/fsharp-team-msft
When merged, this either needs to be:

  1. Not squashed for blame ignore to work
  2. Update commit after squash

@vzarytovskii vzarytovskii merged commit 0318afd into dotnet:main Jan 12, 2024
28 checks passed
@jsoref jsoref mentioned this pull request Aug 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants