Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite SizeOfValueInfo in Optimizer.fs to be tail-recursive #16559

Merged
merged 2 commits into from
Jan 22, 2024
Merged

rewrite SizeOfValueInfo in Optimizer.fs to be tail-recursive #16559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5149fc3
rewrite SizeOfValueInfo in Optimizer.fs to be tail-recursive
dawedawe Jan 19, 2024
6b18f2c
use Brians rewrite into one local function
dawedawe Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions src/Compiler/Optimize/Optimizer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,20 +230,23 @@ type Summary<'Info> =
// Note, this is a different notion of "size" to the one used for inlining heuristics
//-------------------------------------------------------------------------

let rec SizeOfValueInfos (arr:_[]) =
if arr.Length <= 0 then 0 else max 0 (SizeOfValueInfo arr[0])

and SizeOfValueInfo x =
match x with
| SizeValue (vdepth, _v) -> vdepth // terminate recursion at CACHED size nodes
| ConstValue (_x, _) -> 1
| UnknownValue -> 1
| ValValue (_vr, vinfo) -> SizeOfValueInfo vinfo + 1
| TupleValue vinfos
| RecdValue (_, vinfos)
| UnionCaseValue (_, vinfos) -> 1 + SizeOfValueInfos vinfos
| CurriedLambdaValue _ -> 1
| ConstExprValue (_size, _) -> 1
let SizeOfValueInfo valueInfo =
let rec loop acc valueInfo =
match valueInfo with
| SizeValue (vdepth, _v) -> assert (vdepth >= 0); acc + vdepth // terminate recursion at CACHED size nodes
| CurriedLambdaValue _
| ConstExprValue _
| ConstValue _
| UnknownValue -> acc + 1
| TupleValue vinfos
| RecdValue (_, vinfos)
| UnionCaseValue (_, vinfos) when vinfos.Length = 0 -> acc + 1
| TupleValue vinfos
| RecdValue (_, vinfos)
| UnionCaseValue (_, vinfos) -> loop (acc + 1) vinfos[0]
| ValValue (_vr, vinfo) -> loop (acc + 1) vinfo

loop 0 valueInfo

let [<Literal>] minDepthForASizeNode = 5 // for small vinfos do not record size info, save space

Expand Down
Loading