Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parens: Keep parens for problematic exprs in $"{(…):N0}", $"{(…),-3}", etc. #16578

Conversation

brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Jan 24, 2024

Description

Another followup to #16079.

  • Keep parens for problematic exprs (if, match, etc.) in $"{(…):N0}", $"{(…),-3}", etc.

Checklist

  • Test cases added.
  • Release notes entry updated.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@brianrourkeboll brianrourkeboll marked this pull request as ready for review January 24, 2024 00:16
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner January 24, 2024 00:16
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brianrourkeboll
Copy link
Contributor Author

@psfinaki this just needs an azp rerun.

@psfinaki
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

@brianrourkeboll FYI a small lif#hack: you can force it by closing and reopening the PR :)

@psfinaki psfinaki merged commit 9ae94bb into dotnet:main Jan 26, 2024
28 checks passed
@brianrourkeboll brianrourkeboll deleted the parens-interpolated-strings-with-qualifiers branch January 26, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants