-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't crash graph checking on invalid syntax #16588
Conversation
|
That must have to do with the fact that it needs a restart to actually start using it. But some of the options are read on every file check so there must be some mismatch. Should hopefully be easy to fix. |
The test failure here also looks suspicious, most likely a bug.
|
tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/FileContentMappingTests.fs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I crashed your merge but otherwise good stuff - thanks :)
Another case similar to #16575
Ends up throwing in VS with Transparent Compiler as you're typing.