Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky transparent compiler tests #16765

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Feb 26, 2024

Issue tracking re-enablement: #16766

Copy link
Contributor

✅ No release notes required

Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss wanted to do the same, thanks

@vzarytovskii vzarytovskii enabled auto-merge (squash) February 26, 2024 17:58
@vzarytovskii vzarytovskii merged commit bc3dd9f into main Feb 26, 2024
29 checks passed
@0101
Copy link
Contributor

0101 commented Feb 26, 2024

Was this the new test added recently in #16720 ? Or did any of the original tests fail? I think that one is just flaky but maybe we can keep the rest? Or it would be nice to get a link to the failures if there were any.

@vzarytovskii
Copy link
Member Author

Was this the new test added recently in #16720 ? Or did any of the original tests fail? I think that one is just flaky but maybe we can keep the rest? Or it would be nice to get a link to the failures if there were any.

I was just being on the safe side and replacing most of the places.

@vzarytovskii
Copy link
Member Author

I'll look at those shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants