Reduce calls to checkPathForIllegalChars

[KevinRansom]

This function

type AssemblyReference = 
    member x.SimpleAssemblyNameIs(name) = 

calls fileNameWithoutExtension which in turn calls checkPathForIllegalChars. However, x.SimpleAssemblyNameIs only uses the result of fileNameWithoutExtension to compare with a passed in Value name.

So there is no real reason for validating that fileNameWithoutExtension has illegal chars, since it will just fail to match the name.

This reduces the number of calls from

checkPathForIllegalCharsCalls : {contents = 947;}
fileNameWithoutExtensionCalls : {contents = 745;}

down to

checkPathForIllegalCharsCalls : {contents = 203;}
fileNameWithoutExtensionCalls : {contents = 745;}

[vasily-kirichenko]

< 1000 calls?...

[KevinRansom]

@vasily-kirichenko yes less than 1000 invocations when compiling fsharp.core.dll using the open source build.

[vasily-kirichenko]

It would be more interesting to collect number of calls during editing a file for some time.

[dsyme]

The code looks fine