Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness feature :: New warning for functions insisting on a (WithNull) argument + typar equality fix #16853

Merged
merged 13 commits into from
Mar 19, 2024

fix

850056a
Select commit
Loading
Failed to load commit list.
Merged

Nullness feature :: New warning for functions insisting on a (WithNull) argument + typar equality fix #16853

fix
850056a
Select commit
Loading
Failed to load commit list.
Azure Pipelines / fsharp-ci failed Mar 19, 2024 in 59m 18s

Build #20240319.6 had test failures

5 errors / 1 warnings

Details

Tests

  • Failed: 2 (0.00%)
  • Passed: 60,085 (97.65%)
  • Other: 1,443 (2.35%)
  • Total: 61,530

Annotations

Check failure on line 870 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L870 

Cmd.exe exited with code '1'.

Check failure on line 871 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L871 

Bash exited with code '1'.

Check failure on line 848 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L848 

Bash exited with code '1'.

Check failure on line 42604 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Build log #L42604 

(NETCORE_ENGINEERING_TELEMETRY=Test) Error running tests (exit code '1').

Check failure on line 1 in Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-default-warns

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-default-warns 

NUnit.Framework.AssertionException :   /Users/runner/work/1/s/tests/fsharp/core/auto-widen/preview-default-warns/test.bsl
  Expected: <empty>
  But was:  "Unexpectedly missing (expected, not actual):
    test.fsx(149,39,149,41): typecheck error FS3391: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string) : Xml.Linq.XNamespace' to convert type 'string' to type 'Xml.Linq.XNamespace'. See https://aka.ms/fsharp-implicit-convs. This warning may be disabled using '#nowarn "3391".

Unexpectedly present (actual, not expected):
    test.fsx(149,39,149,41): typecheck error FS3391: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string | null) : Xml.Linq.XNamespace | null' to convert type 'string' to type 'Xml.Linq.XNamespace'. See https://aka.ms/fsharp-implicit-convs. This warning may be disabled using '#nowarn "3391".
"
Raw output 
   at NUnit.Framework.Assert.ReportFailure(String message)
   at NUnit.Framework.Assert.ReportFailure(ConstraintResult result, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression, String message, Object[] args)
   at FSharp.Test.Compiler.Assertions.TextBasedDiagnosticAsserts.withResultsMatchingFile(String path, CompilationResult result) in /Users/runner/work/1/s/tests/FSharp.Test.Utilities/Compiler.fs:line 1620
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.diffNegativeBaseline[a](CompilationUnit cr, String absFolder, String testName, a _version) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 71
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.singleTestBuildAndRunAuxVersion(String folder, FSharpList`1 bonusArgs, ExecutionMode mode, LangVersion langVersion) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 154
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.singleVersionedNegTestAux(String folder, FSharpList`1 bonusArgs, LangVersion version, String testName) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 164
   at Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-default-warns() in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/MigratedCoreTests.fs:line 85
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-warns-on

See this annotation in the file changed.

@azure-pipelines azure-pipelines / fsharp-ci

Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-warns-on 

NUnit.Framework.AssertionException :   /Users/runner/work/1/s/tests/fsharp/core/auto-widen/preview/test.bsl
  Expected: <empty>
  But was:  "Unexpectedly missing (expected, not actual):
    test.fsx(149,39,149,41): typecheck error FS3391: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string) : Xml.Linq.XNamespace' to convert type 'string' to type 'Xml.Linq.XNamespace'. See https://aka.ms/fsharp-implicit-convs. This warning may be disabled using '#nowarn "3391".
    test.fsx(154,18,154,20): typecheck error FS3395: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string) : Xml.Linq.XNamespace' to convert type 'string' to type 'Xml.Linq.XNamespace'.
    test.fsx(159,18,159,21): typecheck error FS3395: This expression uses the implicit conversion 'Xml.Linq.XName.op_Implicit(expandedName: string) : Xml.Linq.XName' to convert type 'string' to type 'Xml.Linq.XName'.

Unexpectedly present (actual, not expected):
    test.fsx(149,39,149,41): typecheck error FS3391: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string | null) : Xml.Linq.XNamespace | null' to convert type 'string' to type 'Xml.Linq.XNamespace'. See https://aka.ms/fsharp-implicit-convs. This warning may be disabled using '#nowarn "3391".
    test.fsx(154,18,154,20): typecheck error FS3395: This expression uses the implicit conversion 'Xml.Linq.XNamespace.op_Implicit(namespaceName: string | null) : Xml.Linq.XNamespace | null' to convert type 'string' to type 'Xml.Linq.XNamespace'.
    test.fsx(159,18,159,21): typecheck error FS3395: This expression uses the implicit conversion 'Xml.Linq.XName.op_Implicit(expandedName: string | null) : Xml.Linq.XName | null' to convert type 'string' to type 'Xml.Linq.XName'.
"
Raw output 
   at NUnit.Framework.Assert.ReportFailure(String message)
   at NUnit.Framework.Assert.ReportFailure(ConstraintResult result, String message, Object[] args)
   at NUnit.Framework.Assert.That[TActual](TActual actual, IResolveConstraint expression, String message, Object[] args)
   at FSharp.Test.Compiler.Assertions.TextBasedDiagnosticAsserts.withResultsMatchingFile(String path, CompilationResult result) in /Users/runner/work/1/s/tests/FSharp.Test.Utilities/Compiler.fs:line 1620
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.diffNegativeBaseline[a](CompilationUnit cr, String absFolder, String testName, a _version) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 71
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.singleTestBuildAndRunAuxVersion(String folder, FSharpList`1 bonusArgs, ExecutionMode mode, LangVersion langVersion) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 154
   at Miscellaneous.FsharpSuiteMigrated.TestFrameworkAdapter.singleVersionedNegTestAux(String folder, FSharpList`1 bonusArgs, LangVersion version, String testName) in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/FsharpSuiteMigrated.fs:line 164
   at Miscellaneous.FsharpSuiteMigrated_CoreTests.auto-widen-version-preview-warns-on() in /Users/runner/work/1/s/tests/FSharp.Compiler.ComponentTests/Miscellaneous/MigratedCoreTests.fs:line 81
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines