Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete attribute is ignored in constructor property assignment. #16900

Merged
merged 24 commits into from
Apr 2, 2024
Merged

Obsolete attribute is ignored in constructor property assignment. #16900

merged 24 commits into from
Apr 2, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Mar 19, 2024 •
edited
Loading

Description

Obsolete attribute is ignored in constructor property assignment.

This PR is the result of the last @amplifying-fsharp session. See https://amplifyingfsharp.io/sessions/2024/03/22/

Fixes #11868 and #16952

Before

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@edgarfgp edgarfgp marked this pull request as ready for review March 26, 2024 12:14
@edgarfgp edgarfgp requested a review from a team as a code owner March 26, 2024 12:14
@edgarfgp
Copy link
Contributor Author

This is ready

@vzarytovskii
Copy link
Member

/run fantomas

@github-actions GitHub Actions
Copy link
Contributor

Failed to run fantomas: https://github.com/dotnet/fsharp/actions/runs/8436391900

@edgarfgp edgarfgp requested a review from T-Gro March 27, 2024 13:16
@edgarfgp
Copy link
Contributor Author

Also manage to fix #16952 as part of this PR. See my last commit

@edgarfgp edgarfgp requested a review from T-Gro March 28, 2024 11:55
psfinaki
psfinaki approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, leaving it to @T-Gro to rereview though.

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Apr 2, 2024

Patience is the mother of all virtues. And the godmother of madness. 😅

T-Gro
T-Gro approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the feedback Edgar, nicely done!

@T-Gro T-Gro merged commit 06c85f0 into dotnet:main Apr 2, 2024
32 checks passed
@edgarfgp edgarfgp mentioned this pull request Apr 2, 2024
Closed
psfinaki pushed a commit that referenced this pull request Apr 3, 2024
@dotnet-bot @edgarfgp
Obsolete attribute was ignored in constructor property assignment. (#…
31fccb7 
…16900) (#16978)

* Raise an warning when Obsolete attribute is used in constructor property assignment.

Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com>
This was referenced Apr 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete attribute is ignored in constructor property assignment
4 participants
@edgarfgp @vzarytovskii @psfinaki @T-Gro