-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parens: undentation in sequentials #16977
Merged
psfinaki
merged 10 commits into
dotnet:main
from
brianrourkeboll:parens-indent-in-sequentials
Apr 15, 2024
Merged
Parens: undentation in sequentials #16977
psfinaki
merged 10 commits into
dotnet:main
from
brianrourkeboll:parens-indent-in-sequentials
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is technically only necessary if the outer sequential is itself nested inside of a list/array/sequence/computation expression where each node of the "sequential" expression is actually an implicit yield, but there is currently no easy, inexpensive way of knowing that.
❗ Release notes required
|
…ndent-in-sequentials
psfinaki
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Please add release notes, otherwise good to go I think :)
T-Gro
approved these changes
Apr 11, 2024
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another followup to #16079.
Description
SynExpr.Sequential
doesn't store presence or range of semicolon;
#16914 would probably still be useful in other scenarios, but I think this is a viable workaround for this particular problem.Examples
Undentation
Nested sequentials
Before, the parens analyzer would suggest:
Checklist