Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo compile before - add fail on plainbuild error #17103

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Redo compile before - add fail on plainbuild error #17103

merged 3 commits into from
Apr 30, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Apr 29, 2024 •
edited
Loading

  • Ensure plainbuild errors fail the CI
  • Fix plainbuild scenarios

@KevinRansom KevinRansom requested a review from a team as a code owner April 29, 2024 19:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 29, 2024
@vzarytovskii vzarytovskii merged commit 12a3277 into dotnet:main Apr 30, 2024
32 checks passed
@dotnet-bot dotnet-bot mentioned this pull request May 11, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 21, 2024
Closed
@vzarytovskii vzarytovskii mentioned this pull request May 27, 2024
Closed
@vzarytovskii vzarytovskii mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @vzarytovskii @T-Gro