.NET 9preview5

.devcontainer/devcontainer.json

@@ -1,12 +1,12 @@
 // For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
 {
     "name": "F#",
-    "image": "mcr.microsoft.com/dotnet/sdk:9.0.100-preview.3",
+    "image": "mcr.microsoft.com/dotnet/sdk:9.0.100-preview.5",
     "features": {
-        "ghcr.io/devcontainers/features/common-utils:2.4.2": {},
+        "ghcr.io/devcontainers/features/common-utils:2.4.3": {},
         "ghcr.io/devcontainers/features/git:1.2.0": {},
         "ghcr.io/devcontainers/features/github-cli:1.0.11": {},
-        "ghcr.io/devcontainers/features/dotnet:2.0.5": {}
+        "ghcr.io/devcontainers/features/dotnet:2.1.0": {}
     },
     "hostRequirements": {
         "cpus": 2,

eng/Build.ps1

@@ -361,7 +361,7 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
     $testLogPath = "$ArtifactsDir\TestResults\$configuration\${projectName}_$targetFramework.xml"
     $testBinLogPath = "$LogDir\${projectName}_$targetFramework.binlog"
     $args = "test $testProject -c $configuration -f $targetFramework -v n --test-adapter-path $testadapterpath --logger ""nunit;LogFilePath=$testLogPath"" /bl:$testBinLogPath"
-    $args += " --blame --results-directory $ArtifactsDir\TestResults\$configuration"
+    $args += " --blame --results-directory $ArtifactsDir\TestResults\$configuration -p:vstestusemsbuildoutput=false"
 
     if (-not $noVisualStudio -or $norestore) {
         $args += " --no-restore"
@@ -391,6 +391,7 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
     }
 }
 
+# TODO: These two has 0 differences, shold be merged, as it just causes confusion, we don't care much about the underlying runner
 function TestUsingXUnit([string] $testProject, [string] $targetFramework, [string]$testadapterpath, [boolean] $asBackgroundJob = $false) {
     TestUsingMsBuild -testProject $testProject -targetFramework $targetFramework -testadapterpath $testadapterpath -noTestFilter $true -asBackgroundJob $asBackgroundJob
 }

eng/SourceBuildPrebuiltBaseline.xml

@@ -9,16 +9,16 @@
       These will go away when repo updates targeting to net8.0
       Tracked with https://github.com/dotnet/fsharp/issues/14765
     -->
-    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Host.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/8.0.2" />
+    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Host.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/8.0.*" />
     <UsagePattern IdentityGlob="System.Configuration.ConfigurationManager/7.0.0" />
     <UsagePattern IdentityGlob="System.Diagnostics.EventLog/7.0.0" />
     <UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/7.0.0" />
 
-    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Runtime.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Crossgen2.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/8.0.2" />
+    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Runtime.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Crossgen2.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/8.0.*" />
 
 
     <!-- Tracked in https://github.com/dotnet/source-build/issues/3438 -->

eng/build.sh

@@ -219,7 +219,7 @@ function TestUsingNUnit() {
   projectname=$(basename -- "$testproject")
   projectname="${projectname%.*}"
   testlogpath="$artifacts_dir/TestResults/$configuration/${projectname}_$targetframework.xml"
-  args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"nunit;LogFilePath=$testlogpath\"$filterArgs --blame --results-directory $artifacts_dir/TestResults/$configuration"
+  args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"nunit;LogFilePath=$testlogpath\"$filterArgs --blame --results-directory $artifacts_dir/TestResults/$configuration -p:vstestusemsbuildoutput=false"
   "$DOTNET_INSTALL_DIR/dotnet" $args || exit $?
 }
 
@@ -325,9 +325,9 @@ BuildSolution
 if [[ "$test_core_clr" == true ]]; then
   coreclrtestframework=$tfm
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.ComponentTests/FSharp.Compiler.ComponentTests.fsproj" --targetframework $coreclrtestframework  --notestfilter 
-  TestUsingXUnit --testproject "$repo_root/tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj" --targetframework $coreclrtestframework  --notestfilter 
+  TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj" --targetframework $coreclrtestframework  --notestfilter 
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharp.Compiler.Private.Scripting.UnitTests.fsproj" --targetframework $coreclrtestframework
-  TestUsingXUnit --testproject "$repo_root/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj" --targetframework $coreclrtestframework
+  TestUsingNUnit --testproject "$repo_root/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj" --targetframework $coreclrtestframework
   TestUsingNUnit --testproject "$repo_root/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj" --targetframework $coreclrtestframework
 fi
 

global.json

@@ -1,10 +1,10 @@
 {
   "sdk": {
-    "version": "9.0.100-preview.3.24204.13",
+    "version": "9.0.100-preview.5.24307.3",
     "allowPrerelease": true
   },
   "tools": {
-    "dotnet": "9.0.100-preview.3.24204.13",
+    "dotnet": "9.0.100-preview.5.24307.3",
     "vs": {
       "version": "17.8",
       "components": [

tests/FSharp.Core.UnitTests/FSharp.Core/OperatorsModuleDynamic.fs

@@ -94,7 +94,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.byte Single.MaxValue
-        Assert.AreEqual(0uy, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(255uy, result)
+        else
+            Assert.AreEqual(0uy, result)
 
         // Overflow
         let result = Operators.byte Double.MinValue
@@ -135,7 +138,12 @@ module OperatorsModuleDynamic =
         // Overflow
         Assert.AreEqual('\000', Operators.char Single.MinValue)
         Assert.AreEqual('\000', Operators.char Double.MinValue)
-        Assert.AreEqual('\000', Operators.char Single.MaxValue)
+
+        if not Info.isNetFramework then
+            Assert.AreEqual('\uffff', Operators.char Single.MaxValue)
+        else
+            Assert.AreEqual('\000', Operators.char Single.MaxValue)
+
         Assert.AreEqual('\000', Operators.char Double.MaxValue)
         CheckThrowsOverflowException(fun () -> Operators.char Decimal.MinValue |> ignore)
 
@@ -286,7 +294,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.int16 Single.MaxValue
-        Assert.AreEqual(0s, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(-1s, result)
+        else
+            Assert.AreEqual(0s, result)
 
         // Overflow
         let result = Operators.int16 Single.MinValue
@@ -338,7 +349,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.int32 Single.MaxValue
-        Assert.AreEqual(Int32.MinValue, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(Int32.MaxValue, result)
+        else
+            Assert.AreEqual(Int32.MinValue, result)
 
         // Overflow
         let result = Operators.int32 Single.MinValue
@@ -391,7 +405,10 @@ module OperatorsModuleDynamic =
 
         // Overflow.
         let result = Operators.int64 Single.MaxValue
-        Assert.AreEqual(Int64.MinValue, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(Int64.MaxValue, result)
+        else
+            Assert.AreEqual(Int64.MinValue, result)
 
         // Overflow
         let result = Operators.int64 Single.MinValue
@@ -444,8 +461,11 @@ module OperatorsModuleDynamic =
         if Info.isX86Runtime then
             Assert.AreEqual(-2147483648n, result)
         else
-            // Cannot use -9223372036854775808, compiler doesn't allow it, see https://github.com/dotnet/fsharp/issues/9524
-            Assert.AreEqual(-9223372036854775807n - 1n, result)
+            if not Info.isNetFramework then
+                Assert.AreEqual(9223372036854775807n, result)
+            else
+                // Cannot use -9223372036854775808, compiler doesn't allow it, see https://github.com/dotnet/fsharp/issues/9524
+                Assert.AreEqual(-9223372036854775807n - 1n, result)
 
         // Overflow (depends on pointer size)
         let result = Operators.nativeint Single.MinValue
@@ -544,7 +564,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.sbyte Single.MaxValue
-        Assert.AreEqual(0y, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(-1y, result)
+        else
+            Assert.AreEqual(0y, result)
 
         // Overflow
         let result = Operators.sbyte Double.MinValue
@@ -596,7 +619,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.uint16 Single.MaxValue
-        Assert.AreEqual(0us, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(65535us, result)
+        else
+            Assert.AreEqual(0us, result)
 
         // Overflow
         let result = Operators.uint16 Single.MinValue
@@ -629,7 +655,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.uint32 Single.MaxValue
-        Assert.AreEqual(0u, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(4294967295u, result)
+        else
+            Assert.AreEqual(0u, result)
 
         // Overflow
         let result = Operators.uint32 Single.MinValue
@@ -679,7 +708,10 @@ module OperatorsModuleDynamic =
 
         // Overflow
         let result = Operators.uint64 Single.MaxValue
-        Assert.AreEqual(0UL, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(18446744073709551615UL, result)
+        else
+            Assert.AreEqual(0UL, result)
 
         // Overflow
         let result = Operators.uint64 Single.MinValue
@@ -721,7 +753,10 @@ module OperatorsModuleDynamic =
 
         // Overflow Single.MaxValue is equal on 32 bits and 64 bits runtimes
         let result = Operators.unativeint Single.MaxValue
-        Assert.AreEqual(0un, result)
+        if not Info.isNetFramework then
+            Assert.AreEqual(18446744073709551615un, result)
+        else
+            Assert.AreEqual(0un, result)
 
         // Overflow (depends on pointer size)
         let result = Operators.unativeint Single.MinValue