Try to add jenkins build of 'net40' without VS installed #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
dsyme
commented
Nov 8, 2016
| @@ -68,7 +71,8 @@ def static getBuildJobName(def configuration, def os) { | |||
| // TODO: set to false after tests are fully enabled | |||
| def skipIfNoTestFiles = true | |||
|
|
|||
| Utilities.setMachineAffinity(newJob, os, os == 'Windows_NT' ? 'latest-dev15' : 'latest-or-auto') | |||
| def affinity = configuration == 'Release_net40_no_vs' ? 'latest-or-auto' : (os == 'Windows_NT' ? 'latest-dev15' : 'latest-or-auto') | |||
There was a problem hiding this comment.
I have no idea where to find out what gets installed with latest-or-auto or latest-dev15 etc., or what the latest allowable values are I've searched around for Utilities.setMachineAffinity but can't find the source for those utilites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1723 fixes the build of 'net40' without VS installed.
This PR attempts to add a CI build of 'net40' without VS installed by using the Jenkins affinity spec
latest-or-autoinstead oflatest-dev15. No tests are run, just build.Because of the way jenkins triggers work, we wil have to accept this PR before it can be tested.
It might be that we have other dependencies (e.g. Windows SDK for sure) but this will help flush out what they are.