-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute targets on unions #17389
Attribute targets on unions #17389
Conversation
❗ Release notes required
|
This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wish we had this proportion of added code and tests in all PRs :D
Thanks Edgar!
Can I get another review please ? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Just a sanity check, |
@vzarytovskii Yes. There are dedicated tests that proves that |
Any chance to get this merged before the nullable PR ? |
Uh oh, I didn't notice the comment before I've pressed merge button, sorry :( |
20c1180
to
7fddd57
Compare
Ok,this is green again |
Thanks @edgarfgp, merging now :) |
Follow up: #17207
Unions compile down to a
class
orstruct
sharplab.This PR enforces the new rules on
unions
.Old rules
New Rules
[<Struct>]
Before sharplab
After
Checklist