Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# protected property can be assigned in a F# inherit constructor call #17391

Merged
merged 15 commits into from
Jul 30, 2024
Merged

C# protected property can be assigned in a F# inherit constructor call #17391

merged 15 commits into from
Jul 30, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jul 8, 2024 •
edited
Loading

Description

Fixes #13299

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@edgarfgp edgarfgp closed this Jul 8, 2024
@edgarfgp edgarfgp reopened this Jul 8, 2024
@edgarfgp edgarfgp closed this Jul 15, 2024
@edgarfgp edgarfgp reopened this Jul 28, 2024
@edgarfgp edgarfgp marked this pull request as ready for review July 29, 2024 20:12
@edgarfgp edgarfgp requested a review from a team as a code owner July 29, 2024 20:12
psfinaki
psfinaki approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, nice fix!

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki enabled auto-merge (squash) July 30, 2024 13:50
@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki psfinaki merged commit ed7905d into dotnet:main Jul 30, 2024
30 checks passed
@edgarfgp
Copy link
Contributor Author

🍻

This was referenced Aug 13, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protected property can't be assigned in inherit constructor call
3 participants
@edgarfgp @psfinaki @vzarytovskii